Alternative to using % to make a variable public

Question

Question

Stella Ticker · Feb 21, 2019

I am reviewing some code where the % sign has been used liberally to name arrays that are worked on by different methods within the same class. Apparently it is not good practice to name variables with a "%" sign as the first character because this could overwrite other similarly named variables from other developers, including ISC! Is there another way to make a variable public ?

Discussion (8)2

Log in or sign up to continue

Alan Thatcher · Feb 21, 2019

To specify the list of public variables for the method, use the following syntax:

Method name(formal_spec) As returnclass [ PublicList = variablelist ]
{
   //implementation
}

Where publiclist is either a single variable name or a comma-separated list of variable names, enclosed in parentheses.

In the documentation search for publiclist and you can get the details

1 0

score 1 · Answer 1 · 2019-02-21T15:47:47-05:00

Goodness me, this works! Thank you

I did have to add the PublicList attribute to both the calling and the invoked methods, otherwise it would not work!

Ex

ClassMethod Main() [PublicList =(var1, var2)]
{
   Do ..InvokedMethod()
   W !,var1
}
ClassMethod InvokedMethod() [PublicList =(var1, var2)]
{
   Set var1 = "ChangedInInvoked
}

score 0 · Answer 2 · 2019-02-22T15:16:22-05:00

Eduard Lebedyuk · Feb 22, 2019

Small addition: objects are always passed by reference, so usually you don't need to pass them with dot.

0 0

score 3 · Answer 3 · 2019-02-21T17:18:32-05:00

for that case passing the variables by reference should be sufficient.

ClassMethod Main() { Do ..InvokedMethod(,var1,.var2) W !,var1 } ClassMethod InvokedMethod(byRef var1, byRef var2) { Set var1 = "ChangedInInvoked" }

score 0 · Answer 4 · 2019-02-23T11:03:07-05:00

Variables should never be global in scope.

As others have said they should be part of class instances or passed by reference.

PPGs are intended more for very local, non persistent, storage - e.g. private data within a spawned job.

score 0 · Answer 5 · 2019-02-25T12:04:37-05:00

Rod Dorman · Feb 25, 2019

The question was about alternatives to using % which is what I answered.

0 0

score 1 · Answer 6 · 2019-02-22T10:41:42-05:00

Rod Dorman · Feb 22, 2019

You could also use process-private globals

1 0

score 0 · Answer 7 · 2019-02-24T05:46:51-05:00

In a true OO-fashion, you should use private properties for that. Available anywhere within your (instantiated) class, but not for the 'outside' world.