All
Accepted answers
Evgeny Shvarov · Feb 22 go to post

Also, never name the classmethod in disp or impl Login() or login() - it compiles, but the IRIS CSP/REST-API  engine doesn't work with such names - it seems they are reserved ones.

Evgeny Shvarov · Feb 21 go to post

Also, make sure you DON'T change the method nomenclature in the impl class - spec compilation will change it (not touching the methods' implementation, though). It can cost you some time to investigate what's going on, as this will appear in the deployment phase only.

e.g. consider method in the impl class:

Classmethod foo (bar as %String) as %Status {
 if bar="" write "bar is empty."
return $$$OK
}

If you change nomenclature, e.g. introduce the default value

Classmethod foo (bar as %String ="" ) as %Status {
 if bar="" write "bar is empty."
return $$$OK
}

It will work on a dev stage, and you will have class with a default value in your GitHub repository, but once the solution is deployed, the spec file compilation will change the nomenclature back to the original "without default" stage, as it is stated according to specs:

Classmethod foo (bar as %String ) as %Status {
 if bar="" write "bar is empty."
return $$$OK
}
Evgeny Shvarov · Feb 19 go to post

"Oh my god!"  Thanks for sharing @Steven Hobbs !

And thanks god we don't have a need to use goto anymore, as it is quite a legal way to shoot yourself in both feet.

Evgeny Shvarov · Feb 16 go to post

Right. I was thinking, too, that AI might code directly in obj-code for "efficiency" maybe with unit-tests keeping "taking care" of logic consistancy.

Evgeny Shvarov · Feb 16 go to post
  • The compiler does not return an error for the QUIT usage as it exits the routine correctly.

BTW, DC AI is wrong here - quit with argument within for loop is not correct.

Evgeny Shvarov · Feb 16 go to post

Thank you, @Dmitrii Baranov !

Just want to assure you, the account is not hacked, yet ;) 

Yes, it may be a strange question (though it is a discussion), but if we put a poll (maybe not a bad idea too), I bet the majority of developers don't use the return command at all. And I remember times when it was introduced to a language (not that long ago). 

That's why AI is not using it in code generation, as it relies on the common practices in the publicly available source codes.

Essentially, I would recommend always using Return to exit a function (as in all other programming languages) and Quit to exit a loop.

Yes, makes sense, thank you. 

Evgeny Shvarov · Feb 14 go to post

Thank you, @Robert Barbiaux ! Love the historic review! It's great to see you find the utility for return command.

p.s. IMHO, generative AIs, while useful in some contexts, are nor artificial, because they are trained with human sourced corpus, nor intelligent, because they are not able of any real creativity and are not doing any reasoning (even if they can mimic both rather well) 😇

Agree! In fact humans can mimic the reasoning perfectly too :)

Evgeny Shvarov · Feb 13 go to post

Thank you @Robert Barbiaux ! Makes sense! I'll take a look if I can implement it vs what I'm doing.

I was thinking of introducing several IRIS web-apps serving one frontend that addresses different parts of logic as a spec file and implementation far beyond 2K of lines already. But not sure if it is a good/bad practice to have several web apps, and if it is a common approach. Of course, it brings a burden of accesses/roles/security whoops, etc.

Evgeny Shvarov · Feb 13 go to post

Thank you, @Scott Weithman, for sharing the real-life cases! This all makes sense!

It'd be ideal to have guidelines on how to better distribute logic among a set of classes for complex solutions.

And I agree IPM can be super-helful not only for distribution and deployment but also for distributing the shared logic over the large solution.

My particular case is rather simpler: I have a full-stack app, and the /app/api spec file is getting bigger and bigger, and the impl class is already more than 2K lines. So I'm inclining to split it but the issue is that the current design of REST-API we have in  InterSystems will demand me to introduce another web app endpoint, so i will have /app/functionality1/api and /app/functionality2/api and so on. 

Evgeny Shvarov · Feb 12 go to post

Why is there so many lines in this class ? 

A lot of logic.

From code quality point of view, a class exceeding 500 lines is usually considered a candidate for refactoring.

So, 1000+ maybe is already a bit off? Is there any industry standard? Or it's difficult ot cope for a human? )

Is the code generated ?

May I not answer on this question? :)