Hi @Evgeny Shvarov,

I, and I think Enrico too, was talking not only of the 16 rules you've selected, but the 100+ rules that are in the product if you buy it.

As far as I can see, the 16 rules are mostly about bugs which should easily be found by simple testing.

One of the biggest problems I have with OQ is that it doesn't expand macros, which gives a lot of false positives.
For instance $$$ReturnError("Illegal argument") isn't regarded as a Return, which is in the macro definition.
The same for $$$Yes, $$$True, etc aren't recognized as legal boolean values.

Silly rules that state that you should use certain syntax formats, such as parenthesis around conditions, because otherwise it is hard to comprehend for people coming from other programming languages.

I don't have the time to go though all rules but I will illustrate with one.

Rule ID:objectscriptquality:OS0078

Incompatible argument type in a method

The title is wrong, it should be "in a method call"

The argument passed must be of the type expected by the method. When no type is defined for a parameter, a %String argument is expected.

The first part of the sentence makes sense, the second is not true for Objectscript. If no type is specified the argument can be of any type.
If this is something you want is another issue.

Sometimes you want an argument to be able to be of different types.
For instance if an argument is of type %Stream, you might want to allow a simple string as a value too.

In general I would say this is not a rule that would enhance the quality of the code.

Then the rule explanation is simply wrong.

In following code, method DoWork2 expects to receive %Numeric as argument and DoWork3 expects to receive %DateTime as argument, but in both cases receive Sample.Person and will raise a "PARAMETER error" message on runtime.

A "PARAMETER error" only occurs when supplying too many arguments in the call and has got nothing to do with the datatypes of those arguments. Besides; running the example code gives no error at all.

Then the example code has several issues, which I won't discuss right now.

I wouldn't know why setting up ECP isn't easy.
Super easy by the Management Portal, but it can also be scripted.
For 'useful' I'd say: just skim through your globals and copy or merge whatever you need.

Hi @Enrico Parisi,
I was going to say "I wasn't aware of that previous discussion", but I saw that I actually contributed to it :-(
Indeed, since February nothing has changed.
We are all busy and apparently didn't have had the time to make our own attributions.
For me, I wouldn't know how to define a CQ rule, SonarCube is Java based AFAIK and I'm not a Java tiger.
It would be great if ISC would set up a GitHub repository with rules to which we can contribute.
I am not involved in the code base that was obliged to use CQ so it doesn't bother me directly anymore.
But SonarCube has some status and if a customer demands that the code base adheres to the rules of such a tool, you're in trouble. Perfectly working code (for years) suddenly has many major and critical 'errors' and you have to explain why that is.
I think no tool is better than a bad tool.
 

If the two systems are at network reach you could use ECP and Remote Database(s).

Then the logic could be rather easily scripted with all the power of ObjectScript at hand.

I wasn't to, but now that you mention it.
I'd like to suggest it to be an open discussion on DC.
 

I find ObjectScript Quality very opinionated with peculiar assumptions and sometimes dead wrong.
We've been using it a lot in one of our projects because the end-customer demanded it, but we need to trun off a lot of silly rules.
It is not a tool I would recommend.

1: Yes 😉
2: See other comment on Quit
3: yes 😉
You should never 'modernize' for the sake of modernizing (refactoring is something else)
ZTrap is not old-fashioned, it's a mechanism other programming languages just don't have.
It is out-of-the-way, is doesn't introduce another stack level and it doesn't need extra indentation, it's just some code that you hope will never be executed, it isn't part of the main logic.
Try-Catch can be very useful for indeed a 'Try' for something you can't be sure how it will behave, such as
{}.%FromJSON(SomeJSON)

The start tag would be right after the XML declaration, i.e. <StartTag (the element name ends when a space is encountered), the end-tag would then be </StartTag. From there find the closing bracket >

Remember FHIR is a very immature 'standard'.
If you jump on the bandwagon, you must be prepared to be agile.
You talk about R5, but R6 is well on its way and, since they actually are STU4, 5, 6 and so on, there is no FHIR 1.0
Some standard bodies opt for stability like Nictiz in the Netherlands, where most of the official specifications are still based on STU3.
Opting for implementation of an immature standard ,one must be prepared for (extreme) agility, otherwise we are all ending op with in-operability because of different incompatible implementations.

You are right, but this was based on your original question: "if they share a common element/ value return 1"

But the code is easily enhanced to return all common values.

What do you expect of such a class (or classes)?
I might have something on the shelf as a skunk project.

We were 'forced' to use CQ by one of our customers and I was rather disappointed about it.
It looks like the designers of those rules didn't have a lot of COS (or even MUMPS) experience.
Maybe we should, as a community, find some kind of consensus what is good  (?) (C)OS code.
ISC is not a good example, their code (completely open for developers to look at, which you find nowhere in the industry): a lot of different styles (don't mention the 'p" and 't' prefixes ... ;-))
I don't have the time to set this up, but am happy to join the discussions.

No, if you build a Git plugin yourself, you will also have to build the Git menu and optional context menu.

Class Git.PlugIn Extends %Studio.SourceControl.Base

Yes, I know, but I was talking about the automatic configuration by the IRIS installer. It seems that it only supports IIS on Windows.